Use getdefaultlocale in fix_encoding

Use getdefaultlocale in fix_encoding

R=dnj@chromium.org, maruel@chromium.org
BUG=595883
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299547

[iannucci, 2016-03-29 22:39:55]

PTAL: getdefaultlocale seems to always return the POSIX-style name+encoding,
which git 2.7.4 is happy with.

[dnj, 2016-03-29 22:43:50]

lgtm

[iannucci, 2016-03-29 22:44:05]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-03-29 22:44:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843843002/1

[commit-bot: I haz the power, 2016-03-29 22:46:31]

Description was changed from

==========
Use getdefaultlocale in fix_encoding

R=dnj@chromium.org, maruel@chromium.org
BUG=595883
==========

to

==========
Use getdefaultlocale in fix_encoding

R=dnj@chromium.org, maruel@chromium.org
BUG=595883

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299547
==========

[commit-bot: I haz the power, 2016-03-29 22:46:32]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299547

[M-A Ruel, 2016-03-30 15:49:16]

On 2016/03/29 22:46:32, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299547

I'm pretty there was a reason for this but I forget exactly. What was the
problem you are trying to solve? It helps on which OS?

[dnj, 2016-03-30 15:51:51]

> I'm pretty there was a reason for this but I forget exactly. What was the
> problem you are trying to solve? It helps on which OS?

This particular problem is b/c the new Git 2.7 environment loads its locale from
the "LC_ALL" variable exported to it from gclient, which is, in turn, derived
from this. It was previously exporting a long-form locale file (e.g., something
like "English_American.UTF-8"), which was not defined in the Git bash
environment. However, the short form of the same locale is.

AFAICT the reason is that we want this is to compel UTF8 output instead of
whatever the default charset is.

[M-A Ruel, 2016-03-30 15:59:50]

On 2016/03/30 15:51:51, dnj wrote:
> > I'm pretty there was a reason for this but I forget exactly. What was the
> > problem you are trying to solve? It helps on which OS?
> 
> This particular problem is b/c the new Git 2.7 environment loads its locale
from
> the "LC_ALL" variable exported to it from gclient, which is, in turn, derived
> from this. It was previously exporting a long-form locale file (e.g.,
something
> like "English_American.UTF-8"), which was not defined in the Git bash
> environment. However, the short form of the same locale is.
> 
> AFAICT the reason is that we want this is to compel UTF8 output instead of
> whatever the default charset is.

That should have been handled by subprocess2 get_english_env().
https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/subproc...