Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 184383003: The Array function must be looked up in the native context. (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

The Array function must be looked up in the native context. Platforms x64, a64, arm and mips had the bug that the array function was looked up in the global context instead of the native context. Fix this, restoring a weakened assert in hydrogen along the way (by the fix for crbug 347528, which helped find this case). R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19597

Patch Set 1 #

Patch Set 2 : Remove the misleading LoadGlobalContext on ia32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -80 lines) Patch
M src/a64/code-stubs-a64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/a64/macro-assembler-a64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/a64/macro-assembler-a64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcarney
lgtm
6 years, 9 months ago (2014-02-28 10:33:40 UTC) #1
mvstanton
6 years, 9 months ago (2014-02-28 10:39:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r19597 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698