Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1843823003: MSE: Protect better against out-of-sequence parser callbacks (Closed)

Created:
4 years, 8 months ago by wolenetz
Modified:
4 years, 8 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_597447_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSE: Protect better against out-of-sequence parser callbacks Adds parser initialization state tracking to MediaSourceState and enforces correct sequencing of parser callbacks with DCHECKs. BUG=597447 Committed: https://crrev.com/1c42c49d49f2edfc5b2681694685c712f03f02fd Cr-Commit-Position: refs/heads/master@{#384087}

Patch Set 1 #

Patch Set 2 : Removed patchset dependency - this can land by itself #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M media/filters/media_source_state.h View 2 chunks +12 lines, -0 lines 0 comments Download
M media/filters/media_source_state.cc View 8 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843823003/20001
4 years, 8 months ago (2016-03-29 22:08:57 UTC) #2
wolenetz
PTAL
4 years, 8 months ago (2016-03-29 22:10:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 00:28:21 UTC) #6
wolenetz
friendly ping :)
4 years, 8 months ago (2016-03-30 18:07:42 UTC) #7
chcunningham
lgtm Thanks Matt
4 years, 8 months ago (2016-03-30 20:40:50 UTC) #8
wolenetz
On 2016/03/30 20:40:50, chcunningham wrote: > lgtm > > Thanks Matt Thanks for reviews.
4 years, 8 months ago (2016-03-30 20:45:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843823003/20001
4 years, 8 months ago (2016-03-30 20:45:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 20:51:09 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:54:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c42c49d49f2edfc5b2681694685c712f03f02fd
Cr-Commit-Position: refs/heads/master@{#384087}

Powered by Google App Engine
This is Rietveld 408576698