Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1843813002: Fix issue with hit testing on the layer tree. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
CC:
ajuma, cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with hit testing on the layer tree. When wheel event listeners were moved to the layer tree instead of on individual layers in https://codereview.chromium.org/1639363002 We should have stopped hit testing on whether there was a wheel event listener or not. These properties are checked on the general page before processing the event. BUG=597913 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/913f48327c7c50fa79df5af74d68fc7af7d3e2f4 Cr-Commit-Position: refs/heads/master@{#383872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dtapuska
4 years, 8 months ago (2016-03-29 21:24:06 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 8 months ago (2016-03-29 21:37:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843813002/1
4 years, 8 months ago (2016-03-29 23:30:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 00:03:53 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:05:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/913f48327c7c50fa79df5af74d68fc7af7d3e2f4
Cr-Commit-Position: refs/heads/master@{#383872}

Powered by Google App Engine
This is Rietveld 408576698