Removed ArgResult in lib/docgen.dart and removed top level variables.

pkg/docgen/bin/docgen.dart

Index: pkg/docgen/bin/docgen.dart
diff --git a/pkg/docgen/bin/docgen.dart b/pkg/docgen/bin/docgen.dart
index df6ce632d55f20297103d3a7db5b599122fe06e3..00ea862d40041282e8bbd8649a7e57b327447f24 100644
--- a/pkg/docgen/bin/docgen.dart
+++ b/pkg/docgen/bin/docgen.dart
@@ -16,8 +16,12 @@ import '../lib/docgen.dart';
 void main() {
   logger.onRecord.listen((record) => print(record.message));
   var results = initArgParser().parse(new Options().arguments);
-  if (results['help']) return;  
-  docgen(results);
+  docgen(results.rest, packageDir: results['package-root'], 

[Andrei Mouravski, 2013/07/02 00:58:29]

Move packageDir: ... to the next line.

[Andrei Mouravski, 2013/07/02 00:58:29]

Also, I think packageDir should be changed to packageRoot

[janicejl, 2013/07/02 01:21:31]

Done.

+      outputToYaml: results['yaml'] || results['output-format'] == 'yaml', 

[Andrei Mouravski, 2013/07/02 00:58:29]

Create a var above this to hold this info.

[janicejl, 2013/07/02 01:21:31]

Done.

+      outputToJson: results['json'] || results['output-format'] == 'json', 

[Andrei Mouravski, 2013/07/02 00:58:29]

Get rid of outputToJson, since it's a negation.

[janicejl, 2013/07/02 01:21:31]

Done.

+      includePrivate: results['include-private'], 
+      includeSdk: results['parse-sdk'] || results['include-sdk'], 
+      parseSdk: results['parse-sdk']);
 }
 
 /**
@@ -32,6 +36,7 @@ ArgParser initArgParser() {
         if (help) {
           logger.info(parser.getUsage());
           logger.info(USAGE);
+          exit(0);

[Andrei Mouravski, 2013/07/02 00:58:29]

Throw an exception instead.

[janicejl, 2013/07/02 01:21:31]

If I throw an exception, wouldn't it cause a stack trace, which will make it
more difficult for the user to read. 

Would it be better to keep it how I had it before and just do

if (results['help']) return; 

in main? 

[Andrei Mouravski, 2013/07/02 02:21:44]

Yeah, but I'd also move the help logging stuff to main, too.

[janicejl, 2013/07/02 17:18:51]

I decided to keep it in the callback so that all the stuff related to help is
kept in one place. Is there a disadvantage to using callbacks or exit(0)?

         }
       });
   parser.addFlag('verbose', abbr: 'v',