Removed ArgResult in lib/docgen.dart and removed top level variables.

pkg/docgen/bin/docgen.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 
 import 'package:args/args.dart';
 import 'package:logging/logging.dart';
 
 import '../lib/docgen.dart';
 
 /**
  * Analyzes Dart files and generates a representation of included libraries, 
  * classes, and members. 
  */
 void main() {
   logger.onRecord.listen((record) => print(record.message));
   var results = initArgParser().parse(new Options().arguments);
-  if (results['help']) return;  
-  docgen(results);
+  docgen(results.rest, packageDir: results['package-root'], 

[Andrei Mouravski, 2013/07/02 00:58:29]

Move packageDir: ... to the next line.

[Andrei Mouravski, 2013/07/02 00:58:29]

Also, I think packageDir should be changed to packageRoot

[janicejl, 2013/07/02 01:21:31]

Done.

+      outputToYaml: results['yaml'] || results['output-format'] == 'yaml', 

[Andrei Mouravski, 2013/07/02 00:58:29]

Create a var above this to hold this info.

[janicejl, 2013/07/02 01:21:31]

Done.

+      outputToJson: results['json'] || results['output-format'] == 'json', 

[Andrei Mouravski, 2013/07/02 00:58:29]

Get rid of outputToJson, since it's a negation.

[janicejl, 2013/07/02 01:21:31]

Done.

+      includePrivate: results['include-private'], 
+      includeSdk: results['parse-sdk'] || results['include-sdk'], 
+      parseSdk: results['parse-sdk']);
 }
 
 /**
  * Creates parser for docgen command line arguments. 
  */
 ArgParser initArgParser() {

[Andrei Mouravski, 2013/07/02 02:21:44]

Probably should be private.

[janicejl, 2013/07/02 17:18:51]

Done.

   var parser = new ArgParser();
   parser.addFlag('help', abbr: 'h', 
       help: 'Prints help and usage information.', 
       negatable: false, 
       callback: (help) {
         if (help) {
           logger.info(parser.getUsage());
           logger.info(USAGE);
+          exit(0);

[Andrei Mouravski, 2013/07/02 00:58:29]

Throw an exception instead.

[janicejl, 2013/07/02 01:21:31]

If I throw an exception, wouldn't it cause a stack trace, which will make it
more difficult for the user to read. 

Would it be better to keep it how I had it before and just do

if (results['help']) return; 

in main? 

[Andrei Mouravski, 2013/07/02 02:21:44]

Yeah, but I'd also move the help logging stuff to main, too.

[janicejl, 2013/07/02 17:18:51]

I decided to keep it in the callback so that all the stuff related to help is
kept in one place. Is there a disadvantage to using callbacks or exit(0)?

         }
       });
   parser.addFlag('verbose', abbr: 'v', 
       help: 'Output more logging information.', negatable: false, 
       callback: (verbose) {
         if (verbose) Logger.root.level = Level.FINEST;
       });
   parser.addOption('output-format', abbr: 'o', 
       help: 'Sets the output format.', 
       allowed: ['yaml', 'json'], 
       allowedHelp: {'yaml' : 'Outputs to YAML. (Default)', 
         'json' : 'Outputs to JSON.'});
   parser.addFlag('yaml', abbr: 'y', 
       help: 'Same as output-format=yaml.', negatable: false);
   parser.addFlag('json', abbr: 'j', 
       help: 'Same as output-format=json.', negatable: false);
   parser.addFlag('include-private', 
       help: 'Flag to include private declarations.', negatable: false);
   parser.addFlag('include-sdk', 
       help: 'Flag to parse SDK Library files.', negatable: false);
   parser.addFlag('parse-sdk', 
       help: 'Parses the SDK libraries only.', 
       defaultsTo: false, negatable: false);
   parser.addOption('package-root', 
       help: "Sets the package root of the library being analyzed.");
   
   return parser;
 }