Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1843793004: Try to fix Windows Dartium build again (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Try to fix Windows Dartium build again BUG= Committed: https://github.com/dart-lang/sdk/commit/a742ea06b3099472955e5040d8a54ffa8977f426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/bin/platform_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
TBR
4 years, 8 months ago (2016-03-30 14:55:23 UTC) #2
zra
Committed patchset #1 (id:1) manually as a742ea06b3099472955e5040d8a54ffa8977f426 (presubmit successful).
4 years, 8 months ago (2016-03-30 14:55:43 UTC) #4
Ivan Posva
4 years, 8 months ago (2016-03-30 16:27:46 UTC) #5
Message was sent while issue was closed. 
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698