Revert of Fast-fail to catch VC++ compiler crashes

Revert of Fast-fail to catch VC++ compiler crashes (patchset #1 id:1 of https://codereview.chromium.org/1834413002/ )

Reason for revert:
clang-cl complains about not understanding /d2FastFail. I added it upstream, but we need to roll that in first (or add !is_clang checks here in the meantime if it's important to have this CL in. The description sounds like it could wait a while, though.)

Original issue's description:
> Fast-fail to catch VC++ compiler crashes
>
> The VC++ compiler and linker default to catching their crashes using
> structure exception handling. They then print out a helpful message.
> This helpful message is rarely enough information to let us diagnose
> what went wrong. crrev.com/1816333002 added /fastfail to the linker
> command line and this adds /d2FastFail to the compiler command line,
> for gyp and gn.
>
> These options are undocumented and unsupported but very handy -
> the linker /fastfail option was crucial in tracking down a linker
> crash.
>
> Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
> Cr-Commit-Position: refs/heads/master@{#383765}

TBR=scottmg@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/230c0945ebcba2b566ea5ce953854164d61c1305
Cr-Commit-Position: refs/heads/master@{#383803}

[Nico, 2016-03-29 20:26:07]

Created Revert of Fast-fail to catch VC++ compiler crashes

[commit-bot: I haz the power, 2016-03-29 20:26:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843783002/1

[scottmg, 2016-03-29 20:26:53]

On 2016/03/29 20:26:30, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1843783002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1843783002/1

Doh, should have thought of that. lgtm

[commit-bot: I haz the power, 2016-03-29 20:27:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 20:28:49]

Description was changed from

==========
Revert of Fast-fail to catch VC++ compiler crashes (patchset #1 id:1 of
https://codereview.chromium.org/1834413002/ )

Reason for revert:
clang-cl complains about not understanding /d2FastFail. I added it upstream, but
we need to roll that in first (or add !is_clang checks here in the meantime if
it's important to have this CL in. The description sounds like it could wait a
while, though.)

Original issue's description:
> Fast-fail to catch VC++ compiler crashes
> 
> The VC++ compiler and linker default to catching their crashes using
> structure exception handling. They then print out a helpful message.
> This helpful message is rarely enough information to let us diagnose
> what went wrong. crrev.com/1816333002 added /fastfail to the linker
> command line and this adds /d2FastFail to the compiler command line,
> for gyp and gn.
> 
> These options are undocumented and unsupported but very handy -
> the linker /fastfail option was crucial in tracking down a linker
> crash.
> 
> Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
> Cr-Commit-Position: refs/heads/master@{#383765}

TBR=scottmg@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Fast-fail to catch VC++ compiler crashes (patchset #1 id:1 of
https://codereview.chromium.org/1834413002/ )

Reason for revert:
clang-cl complains about not understanding /d2FastFail. I added it upstream, but
we need to roll that in first (or add !is_clang checks here in the meantime if
it's important to have this CL in. The description sounds like it could wait a
while, though.)

Original issue's description:
> Fast-fail to catch VC++ compiler crashes
>
> The VC++ compiler and linker default to catching their crashes using
> structure exception handling. They then print out a helpful message.
> This helpful message is rarely enough information to let us diagnose
> what went wrong. crrev.com/1816333002 added /fastfail to the linker
> command line and this adds /d2FastFail to the compiler command line,
> for gyp and gn.
>
> These options are undocumented and unsupported but very handy -
> the linker /fastfail option was crucial in tracking down a linker
> crash.
>
> Committed: https://crrev.com/10b66c067178bfcfb89b20627f9bb4779ac2efeb
> Cr-Commit-Position: refs/heads/master@{#383765}

TBR=scottmg@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/230c0945ebcba2b566ea5ce953854164d61c1305
Cr-Commit-Position: refs/heads/master@{#383803}
==========

[commit-bot: I haz the power, 2016-03-29 20:28:50]

Patchset 1 (id:??) landed as
https://crrev.com/230c0945ebcba2b566ea5ce953854164d61c1305
Cr-Commit-Position: refs/heads/master@{#383803}

[brucedawson, 2016-03-29 20:28:57]

lgtm.

Landing later when clang-cl understands (or at least ignores) /d2FastFail is
fine. There aren't any ongoing compiler crash investigations at the moment.

[brucedawson, 2016-04-13 18:50:29]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1882833003/ by brucedawson@chromium.org.

The reason for reverting is: clang-cl should support this now..