Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1843773003: Move the grid-template shorthand into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address another issue Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
index f6f5292d95529baab1e886e20a05fcb574e5b0a1..fe6b0a8ad48b2416936fed74917316d221bb0d5e 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
@@ -116,13 +116,10 @@ private:
bool consumeColumns(bool important);
bool consumeGridItemPositionShorthand(CSSPropertyID, bool important);
- RawPtr<CSSValue> parseGridTemplateColumns(bool important);
- bool parseGridTemplateRowsAndAreasAndColumns(bool important);
- bool parseGridTemplateShorthand(bool important);
+ bool consumeGridTemplateRowsAndAreasAndColumns(bool important);
+ bool consumeGridTemplateShorthand(bool important);
bool parseGridShorthand(bool important);
bool consumeGridAreaShorthand(bool important);
- RawPtr<CSSValue> parseGridTrackList();
- bool parseGridTrackRepeatFunction(CSSValueList&, bool& isAutoRepeat);
RawPtr<CSSValue> parseGridTrackSize(CSSParserValueList& inputList, TrackSizeRestriction = AllowAll);
RawPtr<CSSPrimitiveValue> parseGridBreadth(CSSParserValue*, TrackSizeRestriction = AllowAll);
bool parseGridLineNames(CSSParserValueList&, CSSValueList&, CSSGridLineNamesValue* = nullptr);
@@ -143,7 +140,6 @@ private:
bool parseCalculation(CSSParserValue*, ValueRange);
RawPtr<CSSPrimitiveValue> createPrimitiveNumericValue(CSSParserValue*);
- RawPtr<CSSCustomIdentValue> createPrimitiveCustomIdentValue(CSSParserValue*);
class ShorthandScope {
STACK_ALLOCATED();
@@ -195,10 +191,6 @@ private:
Member<CSSCalcValue> m_parsedCalculation;
};
-// TODO(rob.buis): should move to CSSPropertyParser after conversion.
-bool allTracksAreFixedSized(CSSValueList&);
-bool parseGridTemplateAreasRow(const String&, NamedGridAreaMap&, const size_t, size_t&);
-
CSSPropertyID unresolvedCSSPropertyID(const CSSParserString&);
CSSValueID cssValueKeywordID(const CSSParserString&);

Powered by Google App Engine
This is Rietveld 408576698