Skip timestamp validation for cached Chrome OS user policy.

Skip timestamp validation for cached Chrome OS user policy.

Devices that can't keep their clocks correct will otherwise ignore the
policy. We're doing the same for device policy already, and the
timestamp checks remain in place for policy updates, so this is OK.

BUG=chromium:347846
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255126

[Mattias Nissler (ping if slow), 2014-02-28 09:37:35]

Another bad time issue :-/

[Joao da Silva, 2014-02-28 10:04:55]

Code lgtm; I think there's another case to handle (inline).

I'd ask Sumit and Will for their opinion on the bug before landing. From my side
this is an improvement, since we've seen lots of issues with wrong times and
policy loading, and rollback attacks are still prevented as long as there is an
existing policy blob.

https://codereview.chromium.org/184373002/diff/1/chrome/browser/chromeos/poli...
File chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc (right):

https://codereview.chromium.org/184373002/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc:261:
CloudPolicyValidatorBase::TIMESTAMP_REQUIRED);
Here too? This would trigger if there is an immediate crash or if there are
flags in about:flags. Can you verify if it repros too?

[Mattias Nissler (ping if slow), 2014-02-28 10:25:16]

https://codereview.chromium.org/184373002/diff/1/chrome/browser/chromeos/poli...
File chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc (right):

https://codereview.chromium.org/184373002/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc:261:
CloudPolicyValidatorBase::TIMESTAMP_REQUIRED);
On 2014/02/28 10:04:55, Joao da Silva wrote:
> Here too? This would trigger if there is an immediate crash or if there are
> flags in about:flags. Can you verify if it repros too?

Yes, good point. I've verified that it indeed reproduces.

[Mattias Nissler (ping if slow), 2014-03-05 07:19:41]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-03-05 07:20:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/184373002/40001

[commit-bot: I haz the power, 2014-03-05 08:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 08:09:10]

Try jobs failed on following builders: linux_chromium_rel

[Mattias Nissler (ping if slow), 2014-03-05 17:16:00]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-03-05 17:17:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/184373002/40001

[commit-bot: I haz the power, 2014-03-05 19:59:53]

Change committed as 255126