Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1843723002: Spurious scrollbars should not be drawn when overflow is applied to a frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: early-return Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/scrollbars/iframe-overflow-scroll-ignored-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 } 342 }
343 343
344 if (isHTMLFrameElement(element) || isHTMLFrameSetElement(element)) { 344 if (isHTMLFrameElement(element) || isHTMLFrameSetElement(element)) {
345 // Frames and framesets never honor position:relative or position:absolu te. This is necessary to 345 // Frames and framesets never honor position:relative or position:absolu te. This is necessary to
346 // fix a crash where a site tries to position these objects. They also n ever honor display. 346 // fix a crash where a site tries to position these objects. They also n ever honor display.
347 style.setPosition(StaticPosition); 347 style.setPosition(StaticPosition);
348 style.setDisplay(BLOCK); 348 style.setDisplay(BLOCK);
349 return; 349 return;
350 } 350 }
351 351
352 if (isHTMLFrameElementBase(element)) {
353 // Frames cannot overflow (they are always the size we ask them to be).
354 // Some compositing code paths may try to draw scrollbars anyhow.
355 style.setOverflowX(OverflowVisible);
356 style.setOverflowY(OverflowVisible);
357 return;
358 }
359
352 if (isHTMLRTElement(element)) { 360 if (isHTMLRTElement(element)) {
353 // Ruby text does not support float or position. This might change with evolution of the specification. 361 // Ruby text does not support float or position. This might change with evolution of the specification.
354 style.setPosition(StaticPosition); 362 style.setPosition(StaticPosition);
355 style.setFloating(NoFloat); 363 style.setFloating(NoFloat);
356 return; 364 return;
357 } 365 }
358 366
359 if (isHTMLMarqueeElement(element)) { 367 if (isHTMLMarqueeElement(element)) {
360 // For now, <marquee> requires an overflow clip to work properly. 368 // For now, <marquee> requires an overflow clip to work properly.
361 style.setOverflowX(OverflowHidden); 369 style.setOverflowX(OverflowHidden);
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 // We want to count vertical percentage paddings/margins on flex items b ecause our current 459 // We want to count vertical percentage paddings/margins on flex items b ecause our current
452 // behavior is different from the spec and we want to gather compatibili ty data. 460 // behavior is different from the spec and we want to gather compatibili ty data.
453 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t()) 461 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t())
454 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical); 462 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical);
455 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( )) 463 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( ))
456 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal); 464 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal);
457 } 465 }
458 } 466 }
459 467
460 } // namespace blink 468 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/scrollbars/iframe-overflow-scroll-ignored-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698