Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1843713002: Revert of [Android] Switch instrumentation tests to platform mode. (RELAND) (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Switch instrumentation tests to platform mode. (RELAND) (patchset #2 id:20001 of https://codereview.chromium.org/1836883002/ ) Reason for revert: broke mojo on Android GN: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/33530 Original issue's description: > [Android] Switch instrumentation tests to platform mode. (RELAND) > > This is a reland of https://codereview.chromium.org/1387933005/ > > BUG=428729 > > Committed: https://crrev.com/a46e07369fc36afae9fab7506640eb76ff9b925a > Cr-Commit-Position: refs/heads/master@{#383729} TBR=mikecase@chromium.org,rnephew@chromium.org,bpastene@chromium.org,martiniss@chromium.org,yfriedman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428729 Committed: https://crrev.com/2617c7e81b90aaead5698a08a2429b698af9d09a Cr-Commit-Position: refs/heads/master@{#383758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M base/android/javatests/src/org/chromium/base/CommandLineInitUtilTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +2 lines, -6 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/test_runner.py View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jbudorick
Created Revert of [Android] Switch instrumentation tests to platform mode. (RELAND)
4 years, 8 months ago (2016-03-29 17:41:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843713002/1
4 years, 8 months ago (2016-03-29 17:42:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 17:42:34 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:44:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2617c7e81b90aaead5698a08a2429b698af9d09a
Cr-Commit-Position: refs/heads/master@{#383758}

Powered by Google App Engine
This is Rietveld 408576698