Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1843693002: Introduce setNeedsActiveStyleUpdate for adding/removing stylesheets. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
Reviewers:
dglazkov
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+prerender_chromium.org, rwlbuis, sof, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce setNeedsActiveStyleUpdate for adding/removing stylesheets. Remove the add/remove/modify methods which did not have different implementations anyway. The plan is to let the async active stylesheet update detect which StyleSheetContents have been added and which have been removed and invalidate style and caches accordingly. I've started to write up the plan here: http://bit.ly/25uxtnU BUG=567021 Committed: https://crrev.com/8d5bee68bf505c4c0c4e1369d3a28d7ce021a6ef Cr-Commit-Position: refs/heads/master@{#384008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -41 lines) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +15 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLStyleElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843693002/1
4 years, 8 months ago (2016-03-29 17:30:09 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 18:57:00 UTC) #4
rune
4 years, 8 months ago (2016-03-30 09:09:39 UTC) #5
dglazkov
lgtm
4 years, 8 months ago (2016-03-30 16:45:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843693002/1
4 years, 8 months ago (2016-03-30 16:48:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 16:53:16 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:55:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d5bee68bf505c4c0c4e1369d3a28d7ce021a6ef
Cr-Commit-Position: refs/heads/master@{#384008}

Powered by Google App Engine
This is Rietveld 408576698