Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1843673002: S390: Fix prologue offset in GeneratePrologue (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix prologue offset in GeneratePrologue Updates the prologue_offset value in LCodeGen::GeneratePrologue after generating ahi/aghi. prologue_offset is used in FindCodeAgeSequence. Failing to update prologue_offset will result in failing to correctly identify the code aging sequence (young). R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/2e48dc018aa432ad02d37f41bc71a2367a33bc48 Cr-Commit-Position: refs/heads/master@{#35112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-03-29 17:00:46 UTC) #1
JoranSiu
On 2016/03/29 17:00:46, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-03-29 17:01:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843673002/1
4 years, 8 months ago (2016-03-29 17:04:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 17:24:41 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:25:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e48dc018aa432ad02d37f41bc71a2367a33bc48
Cr-Commit-Position: refs/heads/master@{#35112}

Powered by Google App Engine
This is Rietveld 408576698