Add another feature flag which allows SuspiciousModule reports to be sent.

Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=598736
Committed: https://crrev.com/aed9c27dd82ab878df3eb253b7a5b09904c88ad9
Cr-Commit-Position: refs/heads/master@{#383825}

[proberge, 2016-03-29 16:36:20]

Description was changed from

==========
Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=
==========

to

==========
Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=598736
==========

[proberge, 2016-03-29 16:36:20]

proberge@chromium.org changed reviewers:
+ grt@chromium.org, robertshield@chromium.org

[robertshield, 2016-03-29 20:14:50]

lgtm

[proberge, 2016-03-29 20:15:10]

The CQ bit was checked by proberge@chromium.org

[commit-bot: I haz the power, 2016-03-29 20:15:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843663002/1

[grt (UTC plus 2), 2016-03-29 20:37:58]

https://codereview.chromium.org/1843663002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/1843663002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:48:
extern const base::Feature kIncidentReportingSuspiciousModuleReporting{
nit: omit extern?
nit: space before { (unless git cl format did this)

https://codereview.chromium.org/1843663002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:983:
} else if (incident->GetType() == IncidentType::SUSPICIOUS_MODULE &&
can't say i like having the service know intimate details about specific types
of incidents. can this decision be offloaded to the incident type itself?

[proberge, 2016-03-29 20:47:11]

https://codereview.chromium.org/1843663002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/1843663002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:983:
} else if (incident->GetType() == IncidentType::SUSPICIOUS_MODULE &&
On 2016/03/29 20:37:58, grt (very slow) wrote:
> can't say i like having the service know intimate details about specific types
> of incidents. can this decision be offloaded to the incident type itself?

Yeah, it's not great. We'll get rid of this piece of code shortly after M50
ships.

[commit-bot: I haz the power, 2016-03-29 21:09:58]

Description was changed from

==========
Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=598736
==========

to

==========
Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=598736
==========

[commit-bot: I haz the power, 2016-03-29 21:09:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 21:11:09]

Description was changed from

==========
Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=598736
==========

to

==========
Add another feature flag which allows SuspiciousModule reports to be sent.

BUG=598736

Committed: https://crrev.com/aed9c27dd82ab878df3eb253b7a5b09904c88ad9
Cr-Commit-Position: refs/heads/master@{#383825}
==========

[commit-bot: I haz the power, 2016-03-29 21:11:11]

Patchset 1 (id:??) landed as
https://crrev.com/aed9c27dd82ab878df3eb253b7a5b09904c88ad9
Cr-Commit-Position: refs/heads/master@{#383825}

[proberge, 2016-04-08 14:56:16]

Patchset #2 (id:20001) has been deleted