content/browser/bluetooth/bluetooth_dispatcher_host.cc - Issue 1843643002: bluetooth: remove duplicate histograming of request device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_dispatcher_host.cc

Issue 1843643002: bluetooth: remove duplicate histograming of request device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/bluetooth/bluetooth_dispatcher_host.cc

diff --git a/content/browser/bluetooth/bluetooth_dispatcher_host.cc b/content/browser/bluetooth/bluetooth_dispatcher_host.cc

index b69fa4fa49f19a3632cda132998f947eec1a764d..674c21cb7468cde2132a5256eedd07777d59250b 100644

--- a/content/browser/bluetooth/bluetooth_dispatcher_host.cc

+++ b/content/browser/bluetooth/bluetooth_dispatcher_host.cc

@@ -1141,8 +1141,6 @@ void BluetoothDispatcherHost::OnRequestDeviceImpl(

const std::vector<BluetoothScanFilter>& filters,

const std::vector<BluetoothUUID>& optional_services) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- RecordWebBluetoothFunctionCall(UMAWebBluetoothFunction::REQUEST_DEVICE);

- RecordRequestDeviceArguments(filters, optional_services);

Jeffrey Yasskin 2016/03/29 15:24:13 I don't see another copy of RecordRequestDeviceArg

ortuno 2016/03/29 15:29:20 Added RecordRequestDeviceArguments to OnRequestDev

VLOG(1) << "requestDevice called with the following filters: ";

for (const BluetoothScanFilter& filter : filters) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »