Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1843643002: bluetooth: remove duplicate histograming of request device. (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 8 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: remove duplicate histograming of request device. BUG=598120 Committed: https://crrev.com/d2c5f54b9da878b08150552525e0a6228d8045cd Cr-Commit-Position: refs/heads/master@{#383766}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix RecordRequestDeviceArguments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ortuno
PTAL
4 years, 8 months ago (2016-03-29 15:03:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843643002/1
4 years, 8 months ago (2016-03-29 15:03:43 UTC) #5
Jeffrey Yasskin
https://codereview.chromium.org/1843643002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc File content/browser/bluetooth/bluetooth_dispatcher_host.cc (left): https://codereview.chromium.org/1843643002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc#oldcode1145 content/browser/bluetooth/bluetooth_dispatcher_host.cc:1145: RecordRequestDeviceArguments(filters, optional_services); I don't see another copy of RecordRequestDeviceArguments.
4 years, 8 months ago (2016-03-29 15:24:13 UTC) #6
ortuno
https://codereview.chromium.org/1843643002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc File content/browser/bluetooth/bluetooth_dispatcher_host.cc (left): https://codereview.chromium.org/1843643002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc#oldcode1145 content/browser/bluetooth/bluetooth_dispatcher_host.cc:1145: RecordRequestDeviceArguments(filters, optional_services); On 2016/03/29 15:24:13, Jeffrey Yasskin wrote: > ...
4 years, 8 months ago (2016-03-29 15:29:20 UTC) #7
Jeffrey Yasskin
LGTM, thanks!
4 years, 8 months ago (2016-03-29 15:33:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843643002/20001
4 years, 8 months ago (2016-03-29 15:36:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 17:57:58 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:59:22 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d2c5f54b9da878b08150552525e0a6228d8045cd
Cr-Commit-Position: refs/heads/master@{#383766}

Powered by Google App Engine
This is Rietveld 408576698