Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 1843603004: Devtools Animations: Correctly sync scrubber when first animation ended (Closed)

Created:
4 years, 8 months ago by samli
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools Animations: Correctly sync scrubber when first animation ended When the first animation of a group of an animation finishes earlier than the rest, it can cause the scrubber synchronisation to fail if it has passed the end time. BUG=598304 Committed: https://crrev.com/73c46ed45857e4aacf70a1375fb97528f3efdaae Cr-Commit-Position: refs/heads/master@{#383918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
samli
4 years, 8 months ago (2016-03-30 02:00:25 UTC) #2
lushnikov
lgtm
4 years, 8 months ago (2016-03-30 03:28:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843603004/1
4 years, 8 months ago (2016-03-30 05:08:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 06:47:12 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 06:48:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73c46ed45857e4aacf70a1375fb97528f3efdaae
Cr-Commit-Position: refs/heads/master@{#383918}

Powered by Google App Engine
This is Rietveld 408576698