Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1843603002: [Layout API] Add LocalFrame::contentLayoutItem and use in VisualViewport (Closed)

Created:
4 years, 8 months ago by pilgrim_google
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Add LocalFrame::contentLayoutItem and use in VisualViewport LocalFrame has a public contentLayoutObject() method that returns a LayoutView*. This needs to go away eventually. To ease migration, I've added a contentLayoutItem() method next to it that returns a LayoutViewItem. I fixed once reference in VisualViewport to call contentLayoutItem() instead of contentLayoutObject() (to access a method that already exists in LayoutViewItem, so no new API methods required). I also simplified some code in FrameView that had been working around the fact that LocalFrame didn't offer a method that returned a LayoutViewItem. There are no functional changes. BUG=499321 Committed: https://crrev.com/1ed9a4dfd34de7d19c6eb8d0bc20dac44f7d355e Cr-Commit-Position: refs/heads/master@{#383783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 8 months ago (2016-03-29 14:30:15 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-03-29 18:47:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843603002/1
4 years, 8 months ago (2016-03-29 18:47:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 18:52:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 18:53:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ed9a4dfd34de7d19c6eb8d0bc20dac44f7d355e
Cr-Commit-Position: refs/heads/master@{#383783}

Powered by Google App Engine
This is Rietveld 408576698