Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1843563002: Linux perf support - fix debug info. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Linux perf support - fix debug info. This fixes support for debug info in perf. Thanks to Stephane Eranian for identifying the problem - debug info event has to be emitted before the code load event. It also seems that perf does not yet support the shorthand for repeated source files in the debug info entry ("\xff\0"), so I changed it to always write the script name. Committed: https://crrev.com/e11b5f7ab5d01f3e54f6de90bfe7c58497dc6161 Cr-Commit-Position: refs/heads/master@{#35092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M src/perf-jit.cc View 5 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-03-29 06:57:28 UTC) #3
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-03-29 06:58:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843563002/1
4 years, 8 months ago (2016-03-29 07:18:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 07:29:37 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 07:29:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e11b5f7ab5d01f3e54f6de90bfe7c58497dc6161
Cr-Commit-Position: refs/heads/master@{#35092}

Powered by Google App Engine
This is Rietveld 408576698