third_party/WebKit/Source/core/fetch/Resource.cpp - Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fetch/Resource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp

index 9dc8f188a53146c13db9049a9729fe72559953d5..83461f82d1fec00f407017c302a58046727c5798 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.cpp

+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp

@@ -267,7 +267,7 @@ void Resource::setDataBufferingPolicy(DataBufferingPolicy dataBufferingPolicy)

setEncodedSize(0);

}

-void Resource::markClientsFinished()

+void Resource::markClientsAndObserversFinished()

{

while (!m_clients.isEmpty()) {

HashCountedSet<ResourceClient*>::iterator it = m_clients.begin();

@@ -290,7 +290,7 @@ void Resource::error(Resource::Status status)

ASSERT(errorOccurred());

m_data.clear();

checkNotify();

- markClientsFinished();

+ markClientsAndObserversFinished();

}

void Resource::finish()

@@ -299,7 +299,7 @@ void Resource::finish()

if (!errorOccurred())

m_status = Cached;

checkNotify();

- markClientsFinished();

+ markClientsAndObserversFinished();

}

AtomicString Resource::httpContentType() const

« third_party/WebKit/Source/core/fetch/ImageResource.cpp ('K') | « third_party/WebKit/Source/core/fetch/Resource.h ('k') | no next file » | no next file with comments »