Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1843533003: [turbofan] Introduce NumberFloor simplified operator. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce NumberFloor simplified operator. The NumberFloor operator matches exactly the semantics of the Math.floor builtin on Numbers. It uses hardware rounding instructions if available, but provides a full fallback solution that is compatible with Math.floor. The lowering is optimizable based on types if needed later, i.e. we already optimize it for the case that the input is already an Integer (in the EcmaScript sense, including NaN and -0), but we could add more optimizations, like combining NumberFloor and NumberDivide in the future, if necessary. R=jarin@chromium.org BUG=v8:2890, v8:4059 LOG=n Committed: https://crrev.com/43216574ef7969de475fbea0b5276d4a12737686 Cr-Commit-Position: refs/heads/master@{#35090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -7 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +131 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-03-29 05:56:25 UTC) #1
Benedikt Meurer
Hey Jaro, This removes another machine operator from the JavaScript level (namely Float64RoundDown) and introduces ...
4 years, 8 months ago (2016-03-29 05:58:28 UTC) #2
Jarin
lgtm. (Although with our effect chain scheduling phase, the simplified lowering part will have to ...
4 years, 8 months ago (2016-03-29 06:07:23 UTC) #3
Benedikt Meurer
On 2016/03/29 06:07:23, Jarin wrote: > lgtm. (Although with our effect chain scheduling phase, the ...
4 years, 8 months ago (2016-03-29 06:13:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843533003/1
4 years, 8 months ago (2016-03-29 06:13:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 06:18:26 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 06:20:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43216574ef7969de475fbea0b5276d4a12737686
Cr-Commit-Position: refs/heads/master@{#35090}

Powered by Google App Engine
This is Rietveld 408576698