Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 1843513003: tests to assert completion suggestion replacementLength includes entire URI (Closed)

Created:
4 years, 8 months ago by danrubel
Modified:
4 years, 8 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 8 months ago (2016-03-29 12:36:32 UTC) #2
jwren
On 2016/03/29 12:36:32, danrubel wrote: LGTM
4 years, 8 months ago (2016-03-30 20:02:54 UTC) #3
danrubel
4 years, 8 months ago (2016-03-31 16:38:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3b18b656c389f9682694b250be33dee4f126fe2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698