experimental/PdfViewer/SkPdfFont.cpp - Issue 18435007: pdf viewer: refactor and fix a bug (SkPdfobject should not reset on destruct)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: experimental/PdfViewer/SkPdfFont.cpp

Issue 18435007: pdf viewer: refactor and fix a bug (SkPdfobject should not reset on destruct) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #include "SkPdfFont.h"	1 #include "SkPdfFont.h"

2 #include "SkPdfParser.h"

3	2

4 #include "SkStream.h"	3 #include "SkStream.h"

5 #include "SkTypeface.h"	4 #include "SkTypeface.h"

6 #include "SkPdfNativeTokenizer.h"	5 #include "SkPdfNativeTokenizer.h"

7	6

8 std::map<std::string, SkPdfStandardFontEntry>& getStandardFonts() {	7 std::map<std::string, SkPdfStandardFontEntry>& getStandardFonts() {

9 static std::map<std::string, SkPdfStandardFontEntry> gPdfStandardFonts;	8 static std::map<std::string, SkPdfStandardFontEntry> gPdfStandardFonts;

10	9

11 // TODO (edisonn): , vs - ? what does it mean?	10 // TODO (edisonn): , vs - ? what does it mean?

12 // TODO (edisonn): MT, PS, Oblique=italic?, ... what does it mean?	11 // TODO (edisonn): MT, PS, Oblique=italic?, ... what does it mean?

(...skipping 430 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
443 SkPdfEncoding* SkPdfEncoding::fromName(const char* name) {	442 SkPdfEncoding* SkPdfEncoding::fromName(const char* name) {

444 SkPdfEncoding* encoding = getStandardEncodings()[name];	443 SkPdfEncoding* encoding = getStandardEncodings()[name];

445	444

446 #ifdef PDF_TRACE	445 #ifdef PDF_TRACE

447 if (encoding == NULL) {	446 if (encoding == NULL) {

448 printf("Encoding not found: %s\n", name);	447 printf("Encoding not found: %s\n", name);

449 }	448 }

450 #endif	449 #endif

451 return encoding;	450 return encoding;

452 }	451 }

OLD	NEW

« no previous file with comments | « no previous file | experimental/PdfViewer/SkPdfParser.h » ('j') | no next file with comments »