Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1843483002: Add test code for UsbChooserDialog.java (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
Reviewers:
Finnur, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test code for UsbChooserDialog.java This patch added UsbChooserDialogTest.java to test the class UsbChooserDialog. BUG=591735 Committed: https://crrev.com/bc29520c1589b48edf5a3447bffb33a8761cc59b Cr-Commit-Position: refs/heads/master@{#384832}

Patch Set 1 : added UsbChooserDialogTest.java #

Patch Set 2 : removed unused local variable #

Total comments: 13

Patch Set 3 : address newt@'s comments #

Total comments: 2

Patch Set 4 : address newt@'s comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java View 5 chunks +13 lines, -6 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java View 1 2 3 1 chunk +185 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
juncai
Please take a look.
4 years, 8 months ago (2016-03-28 23:32:12 UTC) #2
newt (away)
finnur: Would you mind taking a look here?
4 years, 8 months ago (2016-03-28 23:48:58 UTC) #4
Finnur
LGTM
4 years, 8 months ago (2016-03-30 13:18:54 UTC) #5
newt (away)
a few minor comments https://codereview.chromium.org/1843483002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java (right): https://codereview.chromium.org/1843483002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java#newcode37 chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java:37: UsbChooserDialogWithFakeNatives(long nativeUsbChooserDialogPtr) { suggestion: I'd ...
4 years, 8 months ago (2016-04-01 17:42:48 UTC) #6
juncai
https://codereview.chromium.org/1843483002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java (right): https://codereview.chromium.org/1843483002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java#newcode37 chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java:37: UsbChooserDialogWithFakeNatives(long nativeUsbChooserDialogPtr) { On 2016/04/01 17:42:48, newt wrote: > ...
4 years, 8 months ago (2016-04-01 23:06:50 UTC) #7
newt (away)
lgtm after one last comment. Thanks for writing these tests :) https://codereview.chromium.org/1843483002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java (right): ...
4 years, 8 months ago (2016-04-02 00:29:56 UTC) #8
juncai
https://codereview.chromium.org/1843483002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java (right): https://codereview.chromium.org/1843483002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java#newcode92 chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java:92: items.setSelection(position); On 2016/04/02 00:29:56, newt wrote: > Modify UI ...
4 years, 8 months ago (2016-04-03 16:19:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843483002/60001
4 years, 8 months ago (2016-04-03 16:20:05 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-03 16:59:52 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 17:01:24 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bc29520c1589b48edf5a3447bffb33a8761cc59b
Cr-Commit-Position: refs/heads/master@{#384832}

Powered by Google App Engine
This is Rietveld 408576698