Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1843473002: Sort analyzer sources (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove generated file and fix misplaced comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7578 lines, -7578 lines) Patch
M pkg/analyzer/benchmark/errors_in_all_libraries.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/visitor.dart View 2 chunks +1323 lines, -1323 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +24 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 5 chunks +178 lines, -178 lines 0 comments Download
M pkg/analyzer/lib/src/summary/base.dart View 2 chunks +21 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 1 85 chunks +3821 lines, -3820 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +15 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +34 lines, -34 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 7 chunks +509 lines, -509 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 2 chunks +137 lines, -137 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 5 chunks +237 lines, -237 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 2 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 12 chunks +1151 lines, -1151 lines 0 comments Download
M pkg/analyzer/test/reflective_tests.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 3 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I didn't make any changes other than sorting (and moving a couple of non-doc comments ...
4 years, 8 months ago (2016-03-28 23:02:57 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-28 23:57:19 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-03-29 00:42:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
513433d514457405664938c5b743bc9209d3db06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698