Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: ui/events/event.cc

Issue 1843433002: mash: Fix DCHECK when clicking on window close box (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/event.h" 5 #include "ui/events/event.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #if defined(USE_X11) 9 #if defined(USE_X11)
10 #include <X11/extensions/XInput2.h> 10 #include <X11/extensions/XInput2.h>
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 void TouchEvent::FixRotationAngle() { 714 void TouchEvent::FixRotationAngle() {
715 while (rotation_angle_ < 0) 715 while (rotation_angle_ < 0)
716 rotation_angle_ += 180; 716 rotation_angle_ += 180;
717 while (rotation_angle_ >= 180) 717 while (rotation_angle_ >= 180)
718 rotation_angle_ -= 180; 718 rotation_angle_ -= 180;
719 } 719 }
720 720
721 //////////////////////////////////////////////////////////////////////////////// 721 ////////////////////////////////////////////////////////////////////////////////
722 // PointerEvent 722 // PointerEvent
723 723
724 bool PointerEvent::CanConvertFrom(const Event& event) {
725 switch (event.type()) {
726 case ET_MOUSE_PRESSED:
727 case ET_MOUSE_DRAGGED:
728 case ET_MOUSE_MOVED:
729 case ET_MOUSE_ENTERED:
730 case ET_MOUSE_EXITED:
731 case ET_MOUSE_RELEASED:
732 case ET_TOUCH_PRESSED:
733 case ET_TOUCH_MOVED:
734 case ET_TOUCH_RELEASED:
735 case ET_TOUCH_CANCELLED:
736 return true;
737 default:
738 return false;
739 }
740 }
741
724 PointerEvent::PointerEvent(const PointerEvent& pointer_event) 742 PointerEvent::PointerEvent(const PointerEvent& pointer_event)
725 : LocatedEvent(pointer_event), 743 : LocatedEvent(pointer_event),
726 pointer_id_(pointer_event.pointer_id()), 744 pointer_id_(pointer_event.pointer_id()),
727 details_(pointer_event.pointer_details()) {} 745 details_(pointer_event.pointer_details()) {}
728 746
729 PointerEvent::PointerEvent(const MouseEvent& mouse_event) 747 PointerEvent::PointerEvent(const MouseEvent& mouse_event)
730 : LocatedEvent(mouse_event), 748 : LocatedEvent(mouse_event),
731 pointer_id_(kMousePointerId), 749 pointer_id_(kMousePointerId),
732 details_(mouse_event.pointer_details()) { 750 details_(mouse_event.pointer_details()) {
733 switch (mouse_event.type()) { 751 switch (mouse_event.type()) {
msw 2016/03/29 17:50:27 nit: DCHECK CanConvertFrom here?
James Cook 2016/03/29 18:23:27 Done.
734 case ET_MOUSE_PRESSED: 752 case ET_MOUSE_PRESSED:
735 SetType(ET_POINTER_DOWN); 753 SetType(ET_POINTER_DOWN);
736 break; 754 break;
737 755
738 case ET_MOUSE_DRAGGED: 756 case ET_MOUSE_DRAGGED:
739 case ET_MOUSE_MOVED: 757 case ET_MOUSE_MOVED:
740 SetType(ET_POINTER_MOVED); 758 SetType(ET_POINTER_MOVED);
741 break; 759 break;
742 760
743 case ET_MOUSE_ENTERED: 761 case ET_MOUSE_ENTERED:
(...skipping 10 matching lines...) Expand all
754 772
755 default: 773 default:
756 NOTREACHED(); 774 NOTREACHED();
757 } 775 }
758 } 776 }
759 777
760 PointerEvent::PointerEvent(const TouchEvent& touch_event) 778 PointerEvent::PointerEvent(const TouchEvent& touch_event)
761 : LocatedEvent(touch_event), 779 : LocatedEvent(touch_event),
762 pointer_id_(touch_event.touch_id()), 780 pointer_id_(touch_event.touch_id()),
763 details_(touch_event.pointer_details()) { 781 details_(touch_event.pointer_details()) {
764 switch (touch_event.type()) { 782 switch (touch_event.type()) {
msw 2016/03/29 17:50:27 nit: DCHECK CanConvertFrom here?
James Cook 2016/03/29 18:23:27 Done.
765 case ET_TOUCH_PRESSED: 783 case ET_TOUCH_PRESSED:
766 SetType(ET_POINTER_DOWN); 784 SetType(ET_POINTER_DOWN);
767 break; 785 break;
768 786
769 case ET_TOUCH_MOVED: 787 case ET_TOUCH_MOVED:
770 SetType(ET_POINTER_MOVED); 788 SetType(ET_POINTER_MOVED);
771 break; 789 break;
772 790
773 case ET_TOUCH_RELEASED: 791 case ET_TOUCH_RELEASED:
774 SetType(ET_POINTER_UP); 792 SetType(ET_POINTER_UP);
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 gfx::PointF(x, y), 1165 gfx::PointF(x, y),
1148 time_stamp, 1166 time_stamp,
1149 flags | EF_FROM_TOUCH), 1167 flags | EF_FROM_TOUCH),
1150 details_(details) { 1168 details_(details) {
1151 } 1169 }
1152 1170
1153 GestureEvent::~GestureEvent() { 1171 GestureEvent::~GestureEvent() {
1154 } 1172 }
1155 1173
1156 } // namespace ui 1174 } // namespace ui
OLDNEW
« no previous file with comments | « ui/events/event.h ('k') | ui/events/event_unittest.cc » ('j') | ui/events/event_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698