mash: Fix DCHECK when clicking on window close box

mash/wm/frame/move_event_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mash/wm/frame/move_event_handler.h"
 
 #include "components/mus/public/cpp/window.h"
 #include "components/mus/public/interfaces/cursor.mojom.h"
 #include "mash/wm/frame/move_loop.h"
 #include "mojo/converters/input_events/input_events_type_converters.h"
@@ skipping 40 matching lines @@
 }
 
 MoveEventHandler::~MoveEventHandler() {
   Detach();
 }
 
 void MoveEventHandler::ProcessLocatedEvent(ui::LocatedEvent* event) {
   const bool had_move_loop = move_loop_.get() != nullptr;
   DCHECK(event->IsMouseEvent() || event->IsTouchEvent());
 
+  // Non-client buttons like the close box capture the mouse during clicks.
+  // Explicitly ignore those events here instead of below because there is no
+  // PointerEvent equivalent into which the event can be converted.
+  if (event->type() == ui::ET_MOUSE_CAPTURE_CHANGED)

[msw, 2016/03/29 15:47:40]

The PointerEvent ctors will NOTREACHED on other mouse and touch event types that
aren't in those switch statements. Should we guard more broadly against these?
Perhaps we should add a pointer event util/factory function that checks if it
can convert, then return false/null if not?
https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/event.cc...

[James Cook, 2016/03/29 17:38:07]

Yeah, good point.  I talked to Sadrul and we decided to add a util function
PointerEvent::CanConvertFrom(const Event&). I looked at doing a factory
function, but almost all callers of the PointerEvent converters have the event
on the stack, so returning nullptr is awkward, and we don't have an
event-representing-null I can use either.

+    return;
+
   // TODO(moshayedi): no need for this once MoveEventHandler directly receives
   // pointer events.
   scoped_ptr<ui::PointerEvent> pointer_event;
   if (event->IsMouseEvent())
     pointer_event.reset(new ui::PointerEvent(*event->AsMouseEvent()));
   else
     pointer_event.reset(new ui::PointerEvent(*event->AsTouchEvent()));
 
   if (move_loop_) {
     if (move_loop_->Move(*pointer_event.get()) == MoveLoop::DONE)
@@ skipping 43 matching lines @@
   event->SetHandled();
 }
 
 void MoveEventHandler::OnWindowDestroying(aura::Window* window) {
   DCHECK_EQ(root_window_, window);
   Detach();
 }
 
 }  // namespace wm
 }  // namespace mash