Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184343014: Add service_worker_provider_id param to ResourceHostMsg_Request. (Closed)

Created:
6 years, 9 months ago by michaeln
Modified:
6 years, 9 months ago
Reviewers:
kinuko, inferno
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, alecflett
Visibility:
Public.

Description

Add service_worker_provider_id param to ResourceHostMsg_Request. TBR=inferno BUG=285976 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255600

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/child/resource_dispatcher.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
michaeln
this one has to wait for https://chromiumcodereview.appspot.com/183993004/ to land (cq seems worse than usual these ...
6 years, 9 months ago (2014-03-06 00:34:42 UTC) #1
kinuko
lgtm
6 years, 9 months ago (2014-03-06 04:13:15 UTC) #2
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 9 months ago (2014-03-06 18:57:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/184343014/40001
6 years, 9 months ago (2014-03-06 19:03:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:26:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 19:26:26 UTC) #6
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 9 months ago (2014-03-06 21:23:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/184343014/60001
6 years, 9 months ago (2014-03-06 21:30:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/184343014/60001
6 years, 9 months ago (2014-03-06 22:10:00 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 13:06:15 UTC) #10
Message was sent while issue was closed. 
Change committed as 255600

Powered by Google App Engine
This is Rietveld 408576698