Issue 184343002: Extract MediaListDirective and SourceListDirective from ContentSecurityPolicy.

Issue 184343002: Extract MediaListDirective and SourceListDirective from ContentSecurityPolicy. (Closed)

Created:
6 years, 9 months ago by Mike West

Modified:
6 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Extract MediaListDirective and SourceListDirective from ContentSecurityPolicy. BUG=346642 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168123

Patch Set 2 : Feedback #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -128 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/ContentSecurityPolicy.cpp	View		2 chunks	+2 lines, -125 lines	0 comments	Download
A	Source/core/frame/csp/CSPDirective.h	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	Source/core/frame/csp/CSPSourceList.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/csp/CSPSourceList.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	Source/core/frame/csp/MediaListDirective.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	Source/core/frame/csp/MediaListDirective.cpp	View		1 chunk	+86 lines, -0 lines	0 comments	Download
A	Source/core/frame/csp/SourceListDirective.h	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	Source/core/frame/csp/SourceListDirective.cpp	View		1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/184343002/diff/1/Source/core/frame/csp/CSPDirective.h File Source/core/frame/csp/CSPDirective.h (right): https://codereview.chromium.org/184343002/diff/1/Source/core/frame/csp/CSPDirective.h#newcode36 Source/core/frame/csp/CSPDirective.h:36: } // namespace WebCore

6 years, 9 months ago (2014-02-28 09:27:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/184343002/20001

6 years, 9 months ago (2014-02-28 09:30:55 UTC) #4

Message was sent while issue was closed.

Change committed as 168123

Expand Messages | Collapse Messages