Issue 18434004: Fix and cleanup can_be_minus_zero computation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18434004: Fix and cleanup can_be_minus_zero computation (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow

Modified:
7 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix and cleanup can_be_minus_zero computation R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15546

Patch Set 2 : fixed nits #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -40 lines)			Patch
	M	src/hydrogen-instructions.cc	View	1	12 chunks	+25 lines, -34 lines	0 comments	Download
	A +	test/mjsunit/compiler/minus-zero.js	View		1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/18434004/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/18434004/diff/1/src/hydrogen-instructions.cc#newcode1807 src/hydrogen-instructions.cc:1807: a->CanBeMinusZero() && Nit: actual condition may fit on ...

7 years, 5 months ago (2013-07-08 10:49:23 UTC) #2

Jakob Kummerow

Thanks, landing. https://codereview.chromium.org/18434004/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/18434004/diff/1/src/hydrogen-instructions.cc#newcode1807 src/hydrogen-instructions.cc:1807: a->CanBeMinusZero() && On 2013/07/08 10:49:23, rossberg wrote: ...

7 years, 5 months ago (2013-07-08 11:12:04 UTC) #3

Jakob Kummerow

7 years, 5 months ago (2013-07-08 11:15:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15546 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18434004: Fix and cleanup can_be_minus_zero computation (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixed nits #

Messages