Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1843333005: Makes WindowTreeClientTest destroy state in TearDown (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes WindowTreeClientTest destroy state in TearDown Problem with waiting for destructor is at that point the MessageLoop has been destroyed, which causes problems with binding code. BUG=598925 TEST=test only change R=ben@chromium.org Committed: https://crrev.com/b96ea97ff5ff29c43314f5925fa37321149725bb Cr-Commit-Position: refs/heads/master@{#384676}

Patch Set 1 #

Patch Set 2 : change tests only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M components/mus/ws/window_tree_client_unittest.cc View 1 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years, 8 months ago (2016-04-01 16:28:20 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-01 18:26:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843333005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843333005/20001
4 years, 8 months ago (2016-04-01 19:31:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 20:22:08 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 20:23:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b96ea97ff5ff29c43314f5925fa37321149725bb
Cr-Commit-Position: refs/heads/master@{#384676}

Powered by Google App Engine
This is Rietveld 408576698