Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1843333002: Fix WebRTC transport to normalize SDP messages. (Closed)

Created:
4 years, 8 months ago by Sergey Ulanov
Modified:
4 years, 8 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebRTC transport to normalize SDP messages. WebRTC generates SDP messages that contain CRLF line endings. Depending on the signaling transport these may be converted to LF, which was causing signature verification to fail. Now SDP is normalized on both ends to use LF line endings. BUG=547158 Committed: https://crrev.com/e7aa37d9324beb59d3d7edd574e13346f1b2283a Cr-Commit-Position: refs/heads/master@{#384322}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M remoting/protocol/webrtc_transport.cc View 1 5 chunks +18 lines, -3 lines 0 comments Download
M remoting/protocol/webrtc_transport_unittest.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
4 years, 8 months ago (2016-03-30 23:23:50 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/1843333002/diff/1/remoting/protocol/webrtc_transport.cc File remoting/protocol/webrtc_transport.cc (right): https://codereview.chromium.org/1843333002/diff/1/remoting/protocol/webrtc_transport.cc#newcode51 remoting/protocol/webrtc_transport.cc:51: // verifications is the same that was signed ...
4 years, 8 months ago (2016-03-31 01:09:38 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1843333002/diff/1/remoting/protocol/webrtc_transport.cc File remoting/protocol/webrtc_transport.cc (right): https://codereview.chromium.org/1843333002/diff/1/remoting/protocol/webrtc_transport.cc#newcode51 remoting/protocol/webrtc_transport.cc:51: // verifications is the same that was signed on ...
4 years, 8 months ago (2016-03-31 16:52:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843333002/20001
4 years, 8 months ago (2016-03-31 16:54:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 17:55:49 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:57:29 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7aa37d9324beb59d3d7edd574e13346f1b2283a
Cr-Commit-Position: refs/heads/master@{#384322}

Powered by Google App Engine
This is Rietveld 408576698