Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 18433: Fix a crasher in the interstitial pages (Closed)

Created:
11 years, 11 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

A crasher would happen if you navigate to a page triggering an interstitial from the new tab page, then press back in the interstitial. The crasher would happen because the navigation controller collects (destroys) the previous tab contents when a navigation is initiated. In this case, when navigating back (by just discarding the non committed entries), it would not be expect that the tab contents would be NULL. It seems we do not need to collect the unused tab contents on NavigateToPendingEntry() since we are collecting any unused TabContents in NavigationController::RendererDidNavigate(). BUG=6408 TEST=From the new page, enter the URL to a malware site (ex: http://ianfette.org), press Back (or close the tab), there should be no crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/tab_contents/navigation_controller.cc View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 11 months ago (2009-01-20 23:25:44 UTC) #1
brettw
11 years, 11 months ago (2009-01-20 23:38:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698