Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1843283003: Fix flaky negative-playback-rate animation test. (Closed)

Created:
4 years, 8 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 8 months ago
Reviewers:
dstockwell
CC:
alancutter (OOO until 2018), darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky negative-playback-rate animation test. The animation-state-changes-negative-playback-rate.html layout test flakily fails due to floating point errors. When setting animation.startTime to (document.timeline.currentTime + duration), a floating point difference can sometimes cause this to be set past the point where the animation would be finished, thus producing an animation that was not running. This patch prevents this from happening by setting the startTime halfway through the animation instead of at the end. BUG=593982 Committed: https://crrev.com/02869b24c40dbab8971b6c6fea16040deae8333b Cr-Commit-Position: refs/heads/master@{#384422}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843283003/1
4 years, 8 months ago (2016-03-31 01:15:13 UTC) #3
suzyh_UTC10 (ex-contributor)
I thought I clicked the button to send this to you for review, but it ...
4 years, 8 months ago (2016-03-31 03:09:11 UTC) #4
dstockwell
lgtm https://codereview.chromium.org/1843283003/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html File third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html (right): https://codereview.chromium.org/1843283003/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html#newcode22 third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html:22: animation.startTime = document.timeline.currentTime + duration/2; Nit. spaces around ...
4 years, 8 months ago (2016-03-31 03:10:13 UTC) #5
suzyh_UTC10 (ex-contributor)
On 2016/03/31 at 03:10:13, dstockwell wrote: > lgtm > > https://codereview.chromium.org/1843283003/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html > File third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html (right): ...
4 years, 8 months ago (2016-03-31 03:12:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843283003/20001
4 years, 8 months ago (2016-03-31 03:13:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/71150)
4 years, 8 months ago (2016-03-31 03:27:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843283003/20001
4 years, 8 months ago (2016-03-31 22:37:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 22:42:42 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 22:44:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02869b24c40dbab8971b6c6fea16040deae8333b
Cr-Commit-Position: refs/heads/master@{#384422}

Powered by Google App Engine
This is Rietveld 408576698