Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: chrome/browser/media/router/media_router_mojo_impl_unittest.cc

Issue 1843263002: Fix extension_id()->kExtensionId in Windows-only test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/media_router_mojo_impl_unittest.cc
diff --git a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
index 6b926b1100a3639303a6b22c59734dc6e32f7afb..370245ee7ac2ec91c58c43d17c3cac3002c68009 100644
--- a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
+++ b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
@@ -1306,7 +1306,7 @@ TEST_F(MediaRouterMojoExtensionTest, EnableMdnsAfterEachRegister) {
.WillOnce(InvokeWithoutArgs([&run_loop]() {
run_loop.Quit();
}));
- EXPECT_CALL(*process_manager_, IsEventPageSuspended(extension_id()))
+ EXPECT_CALL(*process_manager_, IsEventPageSuspended(kExtensionId))
.WillOnce(Return(false));
// EnableMdnsDisocvery() is never called except on Windows.
EXPECT_CALL(mock_media_route_provider_, EnableMdnsDiscovery())
@@ -1322,9 +1322,9 @@ TEST_F(MediaRouterMojoExtensionTest, EnableMdnsAfterEachRegister) {
// Reset the extension by "suspending" and notifying MR.
base::RunLoop run_loop3;
ResetMediaRouteProvider();
- EXPECT_CALL(*process_manager_, IsEventPageSuspended(extension_id()))
+ EXPECT_CALL(*process_manager_, IsEventPageSuspended(kExtensionId))
.WillOnce(Return(true));
- EXPECT_CALL(*process_manager_, WakeEventPage(extension_id(), _))
+ EXPECT_CALL(*process_manager_, WakeEventPage(kExtensionId, _))
.WillOnce(testing::DoAll(
media::RunCallback<1>(true),
InvokeWithoutArgs([&run_loop3]() { run_loop3.Quit(); }),
@@ -1341,7 +1341,7 @@ TEST_F(MediaRouterMojoExtensionTest, EnableMdnsAfterEachRegister) {
.WillOnce(InvokeWithoutArgs([&run_loop4]() {
run_loop4.Quit();
}));
- EXPECT_CALL(*process_manager_, IsEventPageSuspended(extension_id()))
+ EXPECT_CALL(*process_manager_, IsEventPageSuspended(kExtensionId))
.WillOnce(Return(false));
// Expected because it was used to wake up the page.
EXPECT_CALL(mock_media_route_provider_, DetachRoute(mojo::String(kRouteId)));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698