Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1843253003: Fix disassembly with background compilation: parsing can report 'errors' in background compilation (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix disassembly with background compilation: parsing can report 'errors' in background compilation BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f8f120bb17bf511901bfbfacb9b473e92f36509b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 8 months ago (2016-03-31 19:13:49 UTC) #2
rmacnak
lgtm
4 years, 8 months ago (2016-03-31 19:15:26 UTC) #3
srdjan
4 years, 8 months ago (2016-03-31 19:17:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8f120bb17bf511901bfbfacb9b473e92f36509b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698