Factor out the test web contents from the WebContents unit test so that it ca...

Factor out the test web contents from the WebContents unit test so that it can
be used by other tests. Properly hook up the MockRenderProcessHost so it gets
created when initialized by SiteInstances through a factory object. Fix other
bugs with the test harness I found when I switched all the WebContents test
over to using it.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8416

[brettw, 2009-01-20 23:53:15]

There is a new snap up. I forgot to add test_web_contents.* to subversion.

[jcampan, 2009-01-21 00:30:58]

LGTM
some nits

http://codereview.chromium.org/18432/diff/40/45
File chrome/browser/renderer_host/mock_render_process_host.h (right):

http://codereview.chromium.org/18432/diff/40/45#newcode59
Line 59: }
DISALLOW_COPY_...

http://codereview.chromium.org/18432/diff/40/47
File chrome/browser/renderer_host/test_render_view_host.h (right):

http://codereview.chromium.org/18432/diff/40/47#newcode11
Line 11: #include "chrome/browser/tab_contents/test_web_contents.h"
Do you need that include?

http://codereview.chromium.org/18432/diff/40/47#newcode162
Line 162: : rph_factory_(),
Do you need that line?

http://codereview.chromium.org/18432/diff/40/50
File chrome/browser/tab_contents/test_web_contents.cc (right):

http://codereview.chromium.org/18432/diff/40/50#newcode6
Line 6: #include "chrome/browser/tab_contents/test_web_contents.h"
Shouldn't be the 1st include?

http://codereview.chromium.org/18432/diff/40/42
File chrome/browser/tab_contents/web_contents_unittest.cc (right):

http://codereview.chromium.org/18432/diff/40/42#newcode194
Line 194: // is not supposed to overwrite an profile if it's already created.
typo "an profile"

http://codereview.chromium.org/18432/diff/40/42#newcode889
Line 889: /* FIXME(brettw)
Should you file a bug so we don't forget