Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1843173003: Fix strong mode warnings and errors. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
tjblasi
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/glob@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -35 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/ast.dart View 5 chunks +19 lines, -10 lines 0 comments Download
M lib/src/list_tree.dart View 8 chunks +26 lines, -21 lines 0 comments Download
M lib/src/parser.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 8 months ago (2016-03-30 23:01:57 UTC) #1
tjblasi
lgtm
4 years, 8 months ago (2016-03-30 23:24:06 UTC) #2
nweiz
4 years, 8 months ago (2016-04-01 00:14:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22638139cb31d08ebe7afabe8073aab4f217595b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698