Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2637)

Unified Diff: content/shell/renderer/test_runner/TestRunner.cpp

Issue 184313005: Clean up the TestRunner methods exposed for Web Notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/TestRunner.cpp
diff --git a/content/shell/renderer/test_runner/TestRunner.cpp b/content/shell/renderer/test_runner/TestRunner.cpp
index 74d35df32bb8fc2cc1d594c37a583b1a39690e8c..2dcf63a383cf0f8d0fcb5bc34400875f976bbdc1 100644
--- a/content/shell/renderer/test_runner/TestRunner.cpp
+++ b/content/shell/renderer/test_runner/TestRunner.cpp
@@ -296,8 +296,7 @@ TestRunner::TestRunner(TestInterfaces* interfaces)
bindMethod("setMIDIAccessorResult", &TestRunner::setMIDIAccessorResult);
bindMethod("setMIDISysExPermission", &TestRunner::setMIDISysExPermission);
bindMethod("grantWebNotificationPermission", &TestRunner::grantWebNotificationPermission);
- bindMethod("simulateLegacyWebNotificationClick", &TestRunner::simulateLegacyWebNotificationClick);
- bindMethod("cancelAllActiveNotifications", &TestRunner::cancelAllActiveNotifications);
+ bindMethod("simulateWebNotificationClick", &TestRunner::simulateWebNotificationClick);
bindMethod("addMockSpeechInputResult", &TestRunner::addMockSpeechInputResult);
bindMethod("setMockSpeechInputDumpRect", &TestRunner::setMockSpeechInputDumpRect);
bindMethod("addMockSpeechRecognitionResult", &TestRunner::addMockSpeechRecognitionResult);
@@ -323,9 +322,6 @@ TestRunner::TestRunner(TestInterfaces* interfaces)
// The following are stubs.
bindMethod("dumpDatabaseCallbacks", &TestRunner::notImplemented);
- bindMethod("denyWebNotificationPermission", &TestRunner::notImplemented);
- bindMethod("removeAllWebNotificationPermissions", &TestRunner::notImplemented);
- bindMethod("simulateWebNotificationClick", &TestRunner::notImplemented);
bindMethod("setIconDatabaseEnabled", &TestRunner::notImplemented);
bindMethod("setScrollbarPolicy", &TestRunner::notImplemented);
bindMethod("clearAllApplicationCaches", &TestRunner::notImplemented);
@@ -1832,7 +1828,7 @@ void TestRunner::grantWebNotificationPermission(const CppArgumentList& arguments
notification_presenter_->GrantPermission(arguments[0].toString(), permissionGranted);
}
-void TestRunner::simulateLegacyWebNotificationClick(const CppArgumentList& arguments, CppVariant* result)
+void TestRunner::simulateWebNotificationClick(const CppArgumentList& arguments, CppVariant* result)
{
if (arguments.size() != 1 || !arguments[0].isString()) {
result->set(false);
@@ -1841,12 +1837,6 @@ void TestRunner::simulateLegacyWebNotificationClick(const CppArgumentList& argum
result->set(notification_presenter_->SimulateClick(arguments[0].toString()));
}
-void TestRunner::cancelAllActiveNotifications(const CppArgumentList& arguments, CppVariant* result)
-{
- notification_presenter_->CancelAllActiveNotifications();
- result->set(true);
-}
-
void TestRunner::addMockSpeechInputResult(const CppArgumentList& arguments, CppVariant* result)
{
result->setNull();
« no previous file with comments | « content/shell/renderer/test_runner/TestRunner.h ('k') | content/shell/renderer/test_runner/notification_presenter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698