Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 184313005: Clean up the TestRunner methods exposed for Web Notifications. (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Clean up the TestRunner methods exposed for Web Notifications. Rename simulateLegacyWebNotificationClick to simulateWebNotificationClick since it is not specific to legacy notifications. Also remove the cancelAllActiveNotifications method, since it's not currently used and resetting notifications will be done automatically between tests. BUG=349015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256638

Patch Set 1 #

Patch Set 2 : Remove the stubs #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M content/shell/renderer/test_runner/TestRunner.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/shell/renderer/test_runner/TestRunner.cpp View 1 4 chunks +2 lines, -12 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Beverloo
These should be the last TestRunner-side changes, as I think I can write most other ...
6 years, 9 months ago (2014-03-04 16:58:51 UTC) #1
Andrew T Wilson (Slow)
lgtm
6 years, 9 months ago (2014-03-04 21:46:57 UTC) #2
pfeldman
rslgtm
6 years, 9 months ago (2014-03-05 15:15:50 UTC) #3
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-12 17:31:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/184313005/60001
6 years, 9 months ago (2014-03-12 17:32:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/184313005/60001
6 years, 9 months ago (2014-03-12 19:25:58 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 20:53:57 UTC) #7
Message was sent while issue was closed.
Change committed as 256638

Powered by Google App Engine
This is Rietveld 408576698