Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 184313004: Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.h
diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h
index 1960093b04e7a5fa1d68dc705220a752eda461b8..7e2e9abcc03bf06c97564b71913199e3a4b438ca 100644
--- a/Source/core/css/parser/CSSPropertyParser.h
+++ b/Source/core/css/parser/CSSPropertyParser.h
@@ -62,12 +62,11 @@ class UseCounter;
// Outputs: Vector of CSSProperties
class CSSPropertyParser {
+ STACK_ALLOCATED();
public:
- typedef Vector<CSSProperty, 256> ParsedPropertyVector;
-
CSSPropertyParser(OwnPtr<CSSParserValueList>&,
const CSSParserContext&, bool inViewport, bool savedImportant,
- ParsedPropertyVector&, bool& hasFontFaceOnlyValues);
+ WillBeHeapVector<CSSProperty, 256>&, bool& hasFontFaceOnlyValues);
~CSSPropertyParser();
// FIXME: Should this be on a separate ColorParser object?
@@ -381,14 +380,14 @@ private:
const bool m_important; // FIXME: This is only used by font-face-src and unicode-range and undoubtably wrong!
// Outputs:
- ParsedPropertyVector& m_parsedProperties;
+ WillBeHeapVector<CSSProperty, 256>& m_parsedProperties;
bool m_hasFontFaceOnlyValues;
// Locals during parsing:
int m_inParseShorthand;
CSSPropertyID m_currentShorthand;
bool m_implicitShorthand;
- RefPtrWillBePersistent<CSSCalcValue> m_parsedCalculation;
+ RefPtrWillBeRawPtr<CSSCalcValue> m_parsedCalculation;
// FIXME: There is probably a small set of APIs we could expose for these
// classes w/o needing to make them friends.
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698