Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: Source/core/css/CSSValueList.cpp

Issue 184313004: Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValueList.h ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValueList.cpp
diff --git a/Source/core/css/CSSValueList.cpp b/Source/core/css/CSSValueList.cpp
index a229067e6dac457b50fe42b2e32235ad91d44b9b..b41d46560aab423ca4c00ba0417f95995da9fe7c 100644
--- a/Source/core/css/CSSValueList.cpp
+++ b/Source/core/css/CSSValueList.cpp
@@ -53,7 +53,7 @@ bool CSSValueList::removeAll(CSSValue* val)
{
bool found = false;
for (size_t index = 0; index < m_values.size(); index++) {
- RefPtr<CSSValue>& value = m_values.at(index);
+ RefPtrWillBeMember<CSSValue>& value = m_values.at(index);
if (value && val && value->equals(*val)) {
m_values.remove(index);
found = true;
@@ -66,7 +66,7 @@ bool CSSValueList::removeAll(CSSValue* val)
bool CSSValueList::hasValue(CSSValue* val) const
{
for (size_t index = 0; index < m_values.size(); index++) {
- const RefPtr<CSSValue>& value = m_values.at(index);
+ const RefPtrWillBeMember<CSSValue>& value = m_values.at(index);
if (value && val && value->equals(*val))
return true;
}
@@ -135,7 +135,7 @@ bool CSSValueList::equals(const CSSValue& other) const
if (m_values.size() != 1)
return false;
- const RefPtr<CSSValue>& value = m_values[0];
+ const RefPtrWillBeMember<CSSValue>& value = m_values[0];
return value && value->equals(other);
}
@@ -164,6 +164,7 @@ PassRefPtrWillBeRawPtr<CSSValueList> CSSValueList::cloneForCSSOM() const
void CSSValueList::traceAfterDispatch(Visitor* visitor)
{
+ visitor->trace(m_values);
CSSValue::traceAfterDispatch(visitor);
}
« no previous file with comments | « Source/core/css/CSSValueList.h ('k') | Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698