Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: Source/core/css/CSSValueList.h

Issue 184313004: Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/CSSValue.h ('k') | Source/core/css/CSSValueList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 static PassRefPtrWillBeRawPtr<CSSValueList> createFromParserValueList(CSSPar serValueList* list) 46 static PassRefPtrWillBeRawPtr<CSSValueList> createFromParserValueList(CSSPar serValueList* list)
47 { 47 {
48 return adoptRefWillBeRefCountedGarbageCollected(new CSSValueList(list)); 48 return adoptRefWillBeRefCountedGarbageCollected(new CSSValueList(list));
49 } 49 }
50 50
51 size_t length() const { return m_values.size(); } 51 size_t length() const { return m_values.size(); }
52 CSSValue* item(size_t index) { return index < m_values.size() ? m_values[ind ex].get() : 0; } 52 CSSValue* item(size_t index) { return index < m_values.size() ? m_values[ind ex].get() : 0; }
53 const CSSValue* item(size_t index) const { return index < m_values.size() ? m_values[index].get() : 0; } 53 const CSSValue* item(size_t index) const { return index < m_values.size() ? m_values[index].get() : 0; }
54 CSSValue* itemWithoutBoundsCheck(size_t index) { return m_values[index].get( ); } 54 CSSValue* itemWithoutBoundsCheck(size_t index) { return m_values[index].get( ); }
55 55
56 void append(PassRefPtr<CSSValue> value) { m_values.append(value); } 56 void append(PassRefPtrWillBeRawPtr<CSSValue> value) { m_values.append(value) ; }
57 void prepend(PassRefPtr<CSSValue> value) { m_values.prepend(value); } 57 void prepend(PassRefPtrWillBeRawPtr<CSSValue> value) { m_values.prepend(valu e); }
58 bool removeAll(CSSValue*); 58 bool removeAll(CSSValue*);
59 bool hasValue(CSSValue*) const; 59 bool hasValue(CSSValue*) const;
60 PassRefPtrWillBeRawPtr<CSSValueList> copy(); 60 PassRefPtrWillBeRawPtr<CSSValueList> copy();
61 61
62 String customCSSText(CSSTextFormattingFlags = QuoteCSSStringIfNeeded) const; 62 String customCSSText(CSSTextFormattingFlags = QuoteCSSStringIfNeeded) const;
63 bool equals(const CSSValueList&) const; 63 bool equals(const CSSValueList&) const;
64 bool equals(const CSSValue&) const; 64 bool equals(const CSSValue&) const;
65 65
66 bool hasFailedOrCanceledSubresources() const; 66 bool hasFailedOrCanceledSubresources() const;
67 67
68 PassRefPtrWillBeRawPtr<CSSValueList> cloneForCSSOM() const; 68 PassRefPtrWillBeRawPtr<CSSValueList> cloneForCSSOM() const;
69 69
70 void traceAfterDispatch(Visitor*); 70 void traceAfterDispatch(Visitor*);
71 71
72 protected: 72 protected:
73 CSSValueList(ClassType, ValueListSeparator); 73 CSSValueList(ClassType, ValueListSeparator);
74 CSSValueList(const CSSValueList& cloneFrom); 74 CSSValueList(const CSSValueList& cloneFrom);
75 75
76 private: 76 private:
77 explicit CSSValueList(ValueListSeparator); 77 explicit CSSValueList(ValueListSeparator);
78 explicit CSSValueList(CSSParserValueList*); 78 explicit CSSValueList(CSSParserValueList*);
79 79
80 Vector<RefPtr<CSSValue>, 4> m_values; 80 WillBeHeapVector<RefPtrWillBeMember<CSSValue>, 4> m_values;
81 }; 81 };
82 82
83 DEFINE_CSS_VALUE_TYPE_CASTS(CSSValueList, isValueList()); 83 DEFINE_CSS_VALUE_TYPE_CASTS(CSSValueList, isValueList());
84 84
85 // Objects of this class are intended to be stack-allocated and scoped to a sing le function. 85 // Objects of this class are intended to be stack-allocated and scoped to a sing le function.
86 // Please take care not to pass these around as they do hold onto a raw pointer. 86 // Please take care not to pass these around as they do hold onto a raw pointer.
87 class CSSValueListInspector { 87 class CSSValueListInspector {
88 STACK_ALLOCATED(); 88 STACK_ALLOCATED();
89 public: 89 public:
90 CSSValueListInspector(CSSValue* value) : m_list((value && value->isValueList ()) ? toCSSValueList(value) : 0) { } 90 CSSValueListInspector(CSSValue* value) : m_list((value && value->isValueList ()) ? toCSSValueList(value) : 0) { }
(...skipping 18 matching lines...) Expand all
109 void advance() { m_position++; ASSERT(m_position <= m_inspector.length());} 109 void advance() { m_position++; ASSERT(m_position <= m_inspector.length());}
110 size_t index() const { return m_position; } 110 size_t index() const { return m_position; }
111 private: 111 private:
112 CSSValueListInspector m_inspector; 112 CSSValueListInspector m_inspector;
113 size_t m_position; 113 size_t m_position;
114 }; 114 };
115 115
116 } // namespace WebCore 116 } // namespace WebCore
117 117
118 #endif // CSSValueList_h 118 #endif // CSSValueList_h
OLDNEW
« no previous file with comments | « Source/core/css/CSSValue.h ('k') | Source/core/css/CSSValueList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698