Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 18431004: Common implementation of OS::DumpBacktrace() and OS::StackWalk(). (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a common templatized implementation of OS::DumpBacktrace() and OS::StackWalk() to platform-posix.h and use it for Linux, Mac OS X and FreeBSD. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15644

Patch Set 1 #

Total comments: 2

Patch Set 2 : Templatized POSIX backtrace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -124 lines) Patch
M src/platform-freebsd.cc View 1 2 chunks +2 lines, -45 lines 0 comments Download
M src/platform-linux.cc View 1 2 chunks +5 lines, -51 lines 0 comments Download
M src/platform-macos.cc View 1 3 chunks +7 lines, -28 lines 0 comments Download
M src/platform-posix.h View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-12 07:08:41 UTC) #1
Dmitry Lomov (no reviews)
https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc File src/platform-macos.cc (right): https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc#newcode194 src/platform-macos.cc:194: if (backtrace == NULL) return; This code looks a ...
7 years, 5 months ago (2013-07-12 07:46:02 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc File src/platform-macos.cc (right): https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc#newcode194 src/platform-macos.cc:194: if (backtrace == NULL) return; On 2013/07/12 07:46:02, Dmitry ...
7 years, 5 months ago (2013-07-12 07:54:28 UTC) #3
Benedikt Meurer
On 2013/07/12 07:54:28, Benedikt Meurer wrote: > https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc > File src/platform-macos.cc (right): > > https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc#newcode194 ...
7 years, 5 months ago (2013-07-12 08:04:47 UTC) #4
Benedikt Meurer
PTAL
7 years, 5 months ago (2013-07-12 11:07:50 UTC) #5
Dmitry Lomov (no reviews)
lgtm! Nicely done.
7 years, 5 months ago (2013-07-12 11:54:37 UTC) #6
Benedikt Meurer
7 years, 5 months ago (2013-07-12 12:02:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r15644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698