Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1843063005: Add trace event for updateActiveStyleSheets. (Closed)

Created:
2 years, 5 months ago by rune
Modified:
2 years, 5 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trace event for updateActiveStyleSheets. Added for inspecting performance changes for async stylesheet update and show how much time stylesheet update will account for when moved to the updateLayoutTree part of the lifecycle. Will not be called often enough to cause a performance issue in itself. R=mstensho@opera.com BUG=567021 Committed: https://crrev.com/f6c2701c8ad1c3dbde1aafb69f66861dfd1159ec Cr-Commit-Position: refs/heads/master@{#384237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
2 years, 5 months ago (2016-03-31 08:38:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843063005/1
2 years, 5 months ago (2016-03-31 08:38:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
2 years, 5 months ago (2016-03-31 09:49:59 UTC) #5
mstensho (USE GERRIT)
lgtm
2 years, 5 months ago (2016-03-31 10:01:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843063005/1
2 years, 5 months ago (2016-03-31 10:02:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 5 months ago (2016-03-31 10:07:10 UTC) #9
commit-bot: I haz the power
2 years, 5 months ago (2016-03-31 10:08:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6c2701c8ad1c3dbde1aafb69f66861dfd1159ec
Cr-Commit-Position: refs/heads/master@{#384237}

Powered by Google App Engine
This is Rietveld 408576698