chrome/test/media_router/telemetry/benchmarks/pagesets/basic_test.html - Issue 1843063004: Add new Telemetry tests to get CPU and memory usage for idle and flinging two test scenarios. Mirro…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/media_router/telemetry/benchmarks/pagesets/basic_test.html

Issue 1843063004: Add new Telemetry tests to get CPU and memory usage for idle and flinging two test scenarios. Mirro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Jennifer's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py ('K') | « chrome/test/media_router/telemetry/benchmarks/media_router_metric.py ('k') | chrome/test/media_router/telemetry/benchmarks/pagesets/common.js » ('j') | chrome/test/media_router/telemetry/benchmarks/pagesets/common.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html xmlns="http://www.w3.org/1999/xhtml">	2 <html xmlns="http://www.w3.org/1999/xhtml">

3 <head>	3 <head>

4 <title>MR Integration Basic Test</title>	4 <title>MR Integration Basic Test</title>

5 <script type="text/javascript" src="common.js"></script>	5 <script type="text/javascript" src="common.js"></script>

	6 <script type="text/javascript" src="cpu_memory_script.js"></script>

	7 <script type="text/javascript"

	8 src="https://www.gstatic.com/cv/js/sender/v1/cast_sender.js">

	9 </script>

6 </head>	10 </head>

7 <body>	11 <body>

8 <button id="start_session_button" onclick="startSession()">	12 <button id="start_session_button" onclick="startFlingingSession()">
	mark a. foltz 2016/04/18 23:48:11 Are these tests started manually (by clicking a bu Are these tests started manually (by clicking a button) or is this just a debugging page? Lei Lei 2016/04/19 21:56:02 We need to click the button to start a new session Show quoted text On 2016/04/18 23:48:11, mark a. foltz wrote: > Are these tests started manually (by clicking a button) or is this just a > debugging page? We need to click the button to start a new session, but it doesn't require to do it manually, I have code to click the button to start a new session in line 86 in media_router_perf_pages.py. https://codereview.chromium.org/1843063004/diff/160001/chrome/test/media_rout... This is a workaround for user gesture check, otherwise it will be failed to start a new session if presentation.requestSession is called directly in js code.
9 Start session	13 Start session

10 </button>	14 </button>

11 </body>	15 </body>

12 </html>	16 </html>

OLD	NEW