chrome/browser/download/notification/download_item_notification.cc - Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_item_notification.cc

Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Oops mac compile again Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/url_utilities.cc ('k') | chrome/browser/geolocation/geolocation_infobar_delegate_android.h » ('j') | components/url_formatter/elide_url.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_item_notification.cc

diff --git a/chrome/browser/download/notification/download_item_notification.cc b/chrome/browser/download/notification/download_item_notification.cc

index 7907f1b38047af780751acce4f673752b3a06369..180e744c715019eac635107b5b96e361a86e96ca 100644

--- a/chrome/browser/download/notification/download_item_notification.cc

+++ b/chrome/browser/download/notification/download_item_notification.cc

@@ -844,8 +844,8 @@ base::string16 DownloadItemNotification::GetStatusString() const {

return GetWarningStatusString();

// The hostname. (E.g.:"example.com" or "127.0.0.1")

- base::string16 host_name =

- url_formatter::FormatUrlForSecurityDisplayOmitScheme(item_->GetURL());

+ base::string16 host_name = url_formatter::FormatUrlForSecurityDisplay(

+ item_->GetURL(), url_formatter::SchemeDisplay::OMIT_WEB);

DownloadItemModel model(item_);

base::string16 sub_status_text;