components/app_modal/javascript_dialog_manager.cc - Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/javascript_dialog_manager.cc

Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/website_settings.cc ('k') | components/password_manager/core/browser/password_ui_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/app_modal/javascript_dialog_manager.cc

diff --git a/components/app_modal/javascript_dialog_manager.cc b/components/app_modal/javascript_dialog_manager.cc

index 65f212fcce0fc902c14b0811c39479e83bcaf7df..d0e30cf36461d6821a1bb6011fe9af29de201ff1 100644

--- a/components/app_modal/javascript_dialog_manager.cc

+++ b/components/app_modal/javascript_dialog_manager.cc

@@ -267,8 +267,8 @@ base::string16 JavaScriptDialogManager::GetTitle(

base::string16 url_string =

url_formatter::ElideHost(origin_url, gfx::FontList(), kUrlElideWidth);

#else

- base::string16 url_string =

- url_formatter::FormatUrlForSecurityDisplayOmitScheme(origin_url);

+ base::string16 url_string = url_formatter::FormatUrlForSecurityDisplay(

+ origin_url, url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS);

#endif

return l10n_util::GetStringFUTF16(

is_same_origin_as_main_frame ? IDS_JAVASCRIPT_MESSAGEBOX_TITLE