chrome/browser/push_messaging/push_messaging_notification_manager.cc - Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.cc

Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_infobar_delegate.cc ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_notification_manager.cc

diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.cc b/chrome/browser/push_messaging/push_messaging_notification_manager.cc

index c8be882953b1c698eb5a0ee8f2a428388e3d5e88..8ac84582c9d696c9afac4c7a1e472eb683d7e660 100644

--- a/chrome/browser/push_messaging/push_messaging_notification_manager.cc

+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.cc

@@ -67,8 +67,8 @@ NotificationDatabaseData CreateDatabaseData(

const GURL& origin,

int64_t service_worker_registration_id) {

PlatformNotificationData notification_data;

- notification_data.title =

- url_formatter::FormatUrlForSecurityDisplayOmitScheme(origin);

+ notification_data.title = url_formatter::FormatUrlForSecurityDisplay(

+ origin, url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS);

notification_data.direction =

PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT;

notification_data.body =